Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ENABLE_LAPACK as OFF #825

Merged
merged 11 commits into from
Jul 30, 2024
Merged

Default ENABLE_LAPACK as OFF #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
432dee3
initial commit
multiphaseCFD Jul 15, 2024
71c69c7
initial commit
multiphaseCFD Jul 29, 2024
4eb7775
Auto update version from '0.38.0-dev19' to '0.38.0-dev20'
ringo-but-quantum Jul 29, 2024
b0c0bb6
revert some changes
multiphaseCFD Jul 29, 2024
d42eca3
update CI checks
multiphaseCFD Jul 29, 2024
21bdb6a
update changelog
multiphaseCFD Jul 29, 2024
e6d7d5f
Update .github/CHANGELOG.md
multiphaseCFD Jul 29, 2024
615ae2b
revert changes in lgpu_mpi_cpp CI
multiphaseCFD Jul 29, 2024
a0e4322
Update .github/workflows/tests_lgpu_cpp.yml
multiphaseCFD Jul 29, 2024
e4db9d6
update GA names
multiphaseCFD Jul 29, 2024
fabc4a6
Merge branch 'master' into default_enable_lapack_off
multiphaseCFD Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@

### Improvements

* `ENABLE_LAPACK` is off by default for all Lightning backends.
[(#825)](https://github.com/PennyLaneAI/pennylane-lightning/pull/825)

* Update `LightingQubit.preprocess` to work with changes to preprocessing for mid-circuit measurements.
[(#812)](https://github.com/PennyLaneAI/pennylane-lightning/pull/812)

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/tests_lgpu_cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,10 @@ jobs:
strategy:
matrix:
pl_backend: ["lightning_gpu"]
enable_lapack: ["OFF", "ON"]
cuda_version: ["12"]

name: C++ Tests (${{ matrix.pl_backend }}, cuda-${{ matrix.cuda_version }})
name: C++ Tests (${{ matrix.pl_backend }}, cuda-${{ matrix.cuda_version }}, enable_lapack=${{ matrix.enable_lapack }})
runs-on:
- ubuntu-22.04
- self-hosted
Expand Down Expand Up @@ -136,6 +137,7 @@ jobs:
-DCUQUANTUM_SDK=$(python -c "import site; print( f'{site.getsitepackages()[0]}/cuquantum')")\
-DBUILD_TESTS=ON \
-DENABLE_PYTHON=OFF \
-DENABLE_LAPACK=${{ matrix.enable_lapack }} \
-DPL_BACKEND=${{ matrix.pl_backend }} \
-DCMAKE_CXX_COMPILER=$(which g++-$GCC_VERSION) \
-DENABLE_COVERAGE=ON \
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/tests_linux_cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ jobs:
pl_backend: ["lightning_qubit"]
enable_kernel_omp: ["OFF", "ON"]
enable_kernel_avx_streaming: ["OFF", "ON"]
enable_lapack: ["OFF", "ON"]
multiphaseCFD marked this conversation as resolved.
Show resolved Hide resolved
exclude:
- enable_kernel_omp: OFF
enable_kernel_avx_streaming: ON
timeout-minutes: 60
name: C++ Tests (${{ matrix.pl_backend }}, ENABLE_KERNEL_OMP=${{ matrix.enable_kernel_omp }}, ENABLE_KERNEL_AVX_STREAMING=${{ matrix.enable_kernel_avx_streaming }})
name: C++ Tests (${{ matrix.pl_backend }}, ENABLE_KERNEL_OMP=${{ matrix.enable_kernel_omp }}, ENABLE_KERNEL_AVX_STREAMING=${{ matrix.enable_kernel_avx_streaming }}), ENABLE_LAPACK=${{ matrix.enable_lapack }})
multiphaseCFD marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ${{ needs.determine_runner.outputs.runner_group }}

steps:
Expand All @@ -75,6 +76,7 @@ jobs:
-DCMAKE_BUILD_TYPE=Debug \
-DBUILD_TESTS=ON \
-DENABLE_PYTHON=OFF \
-DENABLE_LAPACK=${{ matrix.enable_lapack }} \
-DPL_BACKEND=${{ matrix.pl_backend }} \
-DCMAKE_CXX_COMPILER=$(which g++-$GCC_VERSION) \
-DENABLE_COVERAGE=ON \
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/tests_lkcuda_cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,9 @@ jobs:
pl_backend: ["lightning_kokkos"]
exec_model: ["CUDA"]
kokkos_version: ["4.3.01"]
enable_lapack: ["OFF", "ON"]

name: C++ Tests (${{ matrix.pl_backend }}, kokkos-${{ matrix.kokkos_version }}, model-${{ matrix.exec_model }})
name: C++ Tests (${{ matrix.pl_backend }}, kokkos-${{ matrix.kokkos_version }}, model-${{ matrix.exec_model }}), enable_lapack-${{ matrix.enable_lapack }}
runs-on:
- ${{ matrix.os }}
- self-hosted
Expand Down Expand Up @@ -190,6 +191,7 @@ jobs:
-DCMAKE_BUILD_TYPE=Debug \
-DBUILD_TESTS=ON \
-DENABLE_PYTHON=OFF \
-DENABLE_LAPACK=${{ matrix.enable_lapack }} \
-DCMAKE_PREFIX_PATH=${{ github.workspace }}/Kokkos \
-DPL_BACKEND=${{ matrix.pl_backend }} \
-DCMAKE_CXX_COMPILER=$(which g++-$GCC_VERSION) \
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests_windows_cpp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ jobs:
-DBUILD_TESTS=ON `
-DENABLE_OPENMP=OFF `
-DENABLE_PYTHON=OFF `
-DENABLE_LAPACK=OFF `
-DENABLE_GATE_DISPATCHER=OFF `
-DPL_BACKEND=${{ matrix.pl_backend }} `
-DENABLE_WARNINGS=OFF
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ option(ENABLE_WARNINGS "Enable warnings" ON)
option(ENABLE_NATIVE "Enable native CPU build tuning" OFF)
option(ENABLE_PYTHON "Enable compilation of the Python module" ON)

option(ENABLE_LAPACK "Enable compilation with scipy/LAPACK" ON)
option(ENABLE_LAPACK "Enable compilation with scipy/LAPACK" OFF)

# OpenMP
find_package(OpenMP)
Expand Down
Loading