Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs requirements #594

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Update docs requirements #594

merged 4 commits into from
Jan 15, 2024

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Jan 15, 2024

Context: Sphinx released a new version recently, we need to pin some extensions to keep it working with our pinned Sphinx version.

Description of the Change: Pinning Sphinx extensions.

Benefits: Docs will build

Related PennyLane PRs: PennyLaneAI/pennylane#5062 PennyLaneAI/catalyst#460

@AmintorDusko AmintorDusko marked this pull request as draft January 15, 2024 18:48
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac8795d) 98.96% compared to head (0d44962) 98.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
- Coverage   98.96%   98.67%   -0.30%     
==========================================
  Files         169      169              
  Lines       24308    24308              
==========================================
- Hits        24056    23985      -71     
- Misses        252      323      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko marked this pull request as ready for review January 15, 2024 20:07
@AmintorDusko AmintorDusko requested a review from a team January 15, 2024 20:07
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @AmintorDusko.

@multiphaseCFD multiphaseCFD self-requested a review January 15, 2024 20:34
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, cheers @AmintorDusko .

@AmintorDusko AmintorDusko merged commit 2143239 into master Jan 15, 2024
84 of 85 checks passed
@AmintorDusko AmintorDusko deleted the doc_sphinx_req branch January 15, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants