Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of coverage files sent to CodeCov due to low API limits #584

Merged
merged 18 commits into from
Jan 3, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Jan 2, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: The upload of coverage reports to codecov is currently causing failures due to a failure mode similar to https://community.codecov.com/t/ci-failure-due-to-too-many-uploads-to-this-commit/2587. This PR aims to rename the existing uploaded coverage files to have names unique to each job run, to avoid contention on the server.

Description of the Change: Renames the coverage output files to also include the job run ID.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@mlxd mlxd added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (520b06a) 92.99% compared to head (2cc69fe) 99.07%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   92.99%   99.07%   +6.07%     
==========================================
  Files          58      201     +143     
  Lines        8540    29357   +20817     
==========================================
+ Hits         7942    29084   +21142     
+ Misses        598      273     -325     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trbromley
Copy link
Contributor

trbromley commented Jan 2, 2024

@mlxd can we squeeze in an update to here: https://github.com/PennyLaneAI/pennylane-lightning/blame/489cff75f64fb1ddb706a7e6fa27d1ae15f1c1b0/setup.py#L197
so that we instead point to https://github.com/PennyLaneAI/pennylane-lightning

(you suggested this a few months back)

@mlxd
Copy link
Member Author

mlxd commented Jan 2, 2024

@mlxd can we squeeze in an update to here: https://github.com/PennyLaneAI/pennylane-lightning/blame/489cff75f64fb1ddb706a7e6fa27d1ae15f1c1b0/setup.py#L197 so that we instead point to https://github.com/PennyLaneAI/pennylane-lightning

(you suggested this a few months back)

#581 @dime10 already opened a PR for this

@mlxd mlxd changed the title Add Github Action run id to coverage file names Reduce number of coverage files sent to CodeCov due to low API limits Jan 2, 2024
@mlxd mlxd marked this pull request as ready for review January 3, 2024 14:22
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @mlxd !

@mlxd mlxd merged commit bce3b09 into master Jan 3, 2024
85 checks passed
@mlxd mlxd deleted the codecov_uid branch January 3, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants