-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clang-tidy rules for Lightning builds under aarch64 #567
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 99.02% 99.09% +0.06%
==========================================
Files 168 201 +33
Lines 23235 29203 +5968
==========================================
+ Hits 23009 28938 +5929
- Misses 226 265 +39 ☔ View full report in Codecov by Sentry. |
pennylane_lightning/core/src/simulators/lightning_qubit/gates/GateIndices.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like all the constant definitions. Looks good to me, thanks @mlxd .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mlxd, do you know why we are observing a drop in coverage?
I think this is just due to a reduced line count again --- I don't think any of the test infrastructure changes here, so I'd call it a false flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for that!
Given the %'s, I would say it is because parallel-GPU tests are not run. |
[sc-50799] |
…lightning into clang_tidy_update
|
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: More recent versions of clang-tidy are less permission than those used for the general wheel builders. This PR aims to allow us to use
clang-tidy-16
on platforms such as aarch64. This will also serve as the base to update the clang-tidy rules to a unified format across all repos in 2024.Description of the Change: Removes redundant clang-tidy config files, silences unneeded warnings, and makes source changes to allow clang-tidy passes where useful.
Benefits: Better support for clang-tidy across newer platforms.
Possible Drawbacks:
Related GitHub Issues: Also resolves #560