Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clobbering with multi-backend packaging #504

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Sep 20, 2023

Context: Installing multi-backends clobbers the common core package. This PR allows for sensible install/uninstall of multiple backends.

Description of the Change: Here we make the PennyLane_Lightning package (lightning.qubit) responsible for the core package. Any other package (backends) will require PennyLane_Lightning (same version) from now on.

Benefits: Better and sensible packaging

Possible Drawbacks:

Related GitHub Issues:

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (67aaaf6) 99.08% compared to head (0e94cab) 99.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   99.08%   99.13%   +0.04%     
==========================================
  Files         142      142              
  Lines       16798    16798              
==========================================
+ Hits        16644    16652       +8     
+ Misses        154      146       -8     
Files Changed Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko marked this pull request as ready for review September 21, 2023 11:55
@AmintorDusko AmintorDusko requested a review from a team September 21, 2023 12:47
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko

I think we can opt for this now, and refine the file/package ownerships once we have all 3 devices integrated.

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@AmintorDusko AmintorDusko requested a review from a team September 21, 2023 14:10
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @AmintorDusko .

@AmintorDusko AmintorDusko merged commit 6b8dbac into master Sep 21, 2023
@AmintorDusko AmintorDusko deleted the fix/multi_backend_packaging branch September 21, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants