-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clobbering with multi-backend packaging #504
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 99.08% 99.13% +0.04%
==========================================
Files 142 142
Lines 16798 16798
==========================================
+ Hits 16644 16652 +8
+ Misses 154 146 -8
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AmintorDusko
I think we can opt for this now, and refine the file/package ownerships once we have all 3 devices integrated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @AmintorDusko .
Context: Installing multi-backends clobbers the common
core
package. This PR allows for sensible install/uninstall of multiple backends.Description of the Change: Here we make the PennyLane_Lightning package (
lightning.qubit
) responsible for the core package. Any other package (backends) will require PennyLane_Lightning (same version) from now on.Benefits: Better and sensible packaging
Possible Drawbacks:
Related GitHub Issues: