Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex pattern for exception thrown in tests #318

Merged
merged 7 commits into from
Jul 28, 2022
Merged

Fix regex pattern for exception thrown in tests #318

merged 7 commits into from
Jul 28, 2022

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Jul 27, 2022

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This updates a given test to match a new exception string thrown by PennyLane.

Description of the Change: As above.

Benefits: Ensures all tests pass.

Possible Drawbacks: None

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu

           1 files  ±0             1 suites  ±0   2s ⏱️ -1s
       975 tests ±0         975 ✔️ ±0  0 💤 ±0  0 ±0 
229 280 runs  ±0  229 280 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit e895e92. ± Comparison against base commit c71a74c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #318 (e895e92) into master (c71a74c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          38       38           
  Lines        3920     3920           
=======================================
  Hits         3912     3912           
  Misses          8        8           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71a74c...e895e92. Read the comment docs.

Copy link
Contributor

@chaeyeunpark chaeyeunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Lee.

.github/CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Chae-Yeun Park <[email protected]>
.github/CHANGELOG.md Outdated Show resolved Hide resolved
@multiphaseCFD
Copy link
Member

Thanks @mlxd ! Look fine to me.

@mlxd mlxd merged commit 35a6d41 into master Jul 28, 2022
@mlxd mlxd deleted the fix_tests branch July 28, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants