-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AVX2/512 kernels #313
Add AVX2/512 kernels #313
Conversation
Hello. You may have forgotten to update the changelog!
|
Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu 1 files ± 0 1 suites ±0 2s ⏱️ ±0s Results for commit 740f4b2. ± Comparison against base commit e0768d6. ♻️ This comment has been updated with latest results. |
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
- Coverage 99.79% 99.74% -0.06%
==========================================
Files 40 73 +33
Lines 3929 5108 +1179
==========================================
+ Hits 3921 5095 +1174
- Misses 8 13 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
One subtle point is that enabling |
@mlxd I am still not so sure whether we want to exclude the AVX512 kernel from codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job putting this together @chaeyeunpark
It really helps out. I have some small suggestions, but nothing major.
Happy to give it another pass after this and call it done.
Co-authored-by: Lee James O'Riordan <[email protected]>
Thanks all guys for the sincere reviews! CodeCov is not fully satisfying (it is still >99%), but I want to improve it in the following PRs. It is okay with you? |
Yea, I think this may be sensible since we cannot guarantee what runner we will hit. Fine for me to exclude it completely for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome effort here @chaeyeunpark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Chae-Yeun! Great job!
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: