Fix cpuid.h for ppc and aarch64
#266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 379 379
=========================================
Hits 379 379
Continue to review full report at Codecov.
|
mlxd
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Nice one @chaeyeunpark Happy to see this fix merged.
I think we can look at this for other arch support later (ARM NEON, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a recent push to master, Linux + PPC and ARM64 fail to build wheels as
cpuid.hfile is not found in those environments (see https://github.com/PennyLaneAI/pennylane-lightning/runs/5633549050?check_suite_focus=true and https://github.com/PennyLaneAI/pennylane-lightning/runs/5633549056?check_suite_focus=true).This PR fixes this issue.