Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quantum tapes serialization and Python tests #239

Merged
merged 31 commits into from
Mar 9, 2022

Conversation

maliasadi
Copy link
Member

Context:
Refactoring operations in PennyLane will deprecation a few operations' features including matrix, eigvals and control_wires, and this breaks serialization of quantum tapes and Python tests in Lightning. This PR addresses all DeprecationWarning caused by PR #2023 and also fixes ComplexWarning and UserWarning issues with tests.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #239 (fa75e26) into master (0396af9) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #239      +/-   ##
===========================================
+ Coverage   99.72%   100.00%   +0.27%     
===========================================
  Files           4         4              
  Lines         363       365       +2     
===========================================
+ Hits          362       365       +3     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
pennylane_lightning/_serialize.py 100.00% <100.00%> (ø)
pennylane_lightning/_version.py 100.00% <100.00%> (ø)
pennylane_lightning/lightning_qubit.py 100.00% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0396af9...fa75e26. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   555 tests ±0     555 ✔️ ±0  0 💤 ±0  0 ±0 
2 289 runs  ±0  2 289 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit fa75e26. ± Comparison against base commit 0396af9.

♻️ This comment has been updated with latest results.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @maliasadi
Just a quick question on the parameterized tests, but happy to approve once that is answered.

pennylane_lightning/lightning_qubit.py Outdated Show resolved Hide resolved
tests/test_gates.py Show resolved Hide resolved
tests/test_serialize.py Show resolved Hide resolved
@maliasadi maliasadi requested a review from mlxd March 8, 2022 16:25
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maliasadi
I left one comment, but happy to approve either option :)

pennylane_lightning/_serialize.py Show resolved Hide resolved
@maliasadi maliasadi mentioned this pull request Mar 8, 2022
@maliasadi maliasadi requested a review from mlxd March 9, 2022 05:02
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @maliasadi
Happy to merge!

@maliasadi maliasadi merged commit e113be0 into master Mar 9, 2022
@maliasadi maliasadi deleted the fix_bug_qml_op_matrix_tests branch March 9, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants