-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quantum tapes serialization and Python tests #239
Conversation
…pennylane-lightning into fix_bug_qml_op_matrix_tests
…thon tests and interface
…nto fix_bug_qml_op_matrix_tests
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
===========================================
+ Coverage 99.72% 100.00% +0.27%
===========================================
Files 4 4
Lines 363 365 +2
===========================================
+ Hits 362 365 +3
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
…pennylane-lightning into fix_bug_qml_op_matrix_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @maliasadi
Just a quick question on the parameterized tests, but happy to approve once that is answered.
…pennylane-lightning into fix_bug_qml_op_matrix_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maliasadi
I left one comment, but happy to approve either option :)
…pennylane-lightning into fix_bug_qml_op_matrix_tests
…nto fix_bug_qml_op_matrix_tests
…pennylane-lightning into fix_bug_qml_op_matrix_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @maliasadi
Happy to merge!
Context:
Refactoring operations in PennyLane will deprecation a few operations' features including
matrix
,eigvals
andcontrol_wires
, and this breaks serialization of quantum tapes and Python tests in Lightning. This PR addresses allDeprecationWarning
caused by PR #2023 and also fixesComplexWarning
andUserWarning
issues with tests.