-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cibuildwheel for Python 3.8 #211
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 4 4
Lines 278 277 -1
==========================================
- Hits 277 276 -1
Misses 1 1
Continue to review full report at Codecov.
|
23a8428
to
73a3a68
Compare
This reverts commit 013fe75.
except (ModuleNotFoundError, ImportError): | ||
CPP_BINARY_AVAILABLE = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing the tiny drop in coverage is from here. Maybe adding a quick test to check for the expected exception types may fix the drop, and all the other tests to continue/pass. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Lee, as this became a part of #202, I will close the PR. I was using this PR as a test purpose 🙃
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Fix issue #210
Description of the Change:
ENABLE_WARNINGS=OFF
for building wheelscl.exe
(thus discarding MinGW dependencies).lightning_qubit_ops
is rollbacked.Benefits:
Possible Drawbacks:
Related GitHub Issues: