Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cibuildwheel for Python 3.8 #211

Closed
wants to merge 38 commits into from
Closed

Conversation

chaeyeunpark
Copy link
Contributor

@chaeyeunpark chaeyeunpark commented Jan 16, 2022

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: Fix issue #210

Description of the Change:

  • Add ENABLE_WARNINGS=OFF for building wheels
  • Github workflow for cibuildwheel correctly use cl.exe (thus discarding MinGW dependencies).
  • Loading lightning_qubit_ops is rollbacked.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Jan 16, 2022

Codecov Report

Merging #211 (ecf1f2f) into master (7515848) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.01%     
==========================================
  Files           4        4              
  Lines         278      277       -1     
==========================================
- Hits          277      276       -1     
  Misses          1        1              
Impacted Files Coverage Δ
pennylane_lightning/lightning_qubit.py 99.48% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7515848...ecf1f2f. Read the comment docs.

@chaeyeunpark chaeyeunpark linked an issue Jan 16, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2022

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   388 tests ±0     388 ✔️ ±0  0 💤 ±0  0 ±0 
2 247 runs  ±0  2 247 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit ecf1f2f. ± Comparison against base commit 7515848.

♻️ This comment has been updated with latest results.

@chaeyeunpark chaeyeunpark changed the title [WIP] Fix cibuildwheel py38 Fix cibuildwheel for Python 3.8 Jan 16, 2022
@chaeyeunpark chaeyeunpark requested review from josh146 and mlxd January 17, 2022 04:20
@josh146 josh146 removed their request for review January 17, 2022 05:48
@chaeyeunpark chaeyeunpark force-pushed the fix_cibuildwheel_py38 branch from 23a8428 to 73a3a68 Compare January 17, 2022 16:30
Comment on lines +48 to 49
except (ModuleNotFoundError, ImportError):
CPP_BINARY_AVAILABLE = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing the tiny drop in coverage is from here. Maybe adding a quick test to check for the expected exception types may fix the drop, and all the other tests to continue/pass. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lee, as this became a part of #202, I will close the PR. I was using this PR as a test purpose 🙃

@chaeyeunpark
Copy link
Contributor Author

As PR #202 now contains this PR, we close This PR. #202 will also close issue #211

@chaeyeunpark chaeyeunpark deleted the fix_cibuildwheel_py38 branch January 22, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wheel from cibuildwheel on Windows with Python3.8 is buggy
2 participants