Modify Release to RelWithDebInfo for built wheels #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 4 4
Lines 278 278
=======================================
Hits 277 277
Misses 1 1 Continue to review full report at Codecov.
|
maliasadi
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Very nice improvement! Using RelWithDebInfo instead of Release increases the wheel size, but the code runs still fast and optimize, and has debug information included; thus a great deal to trace and fix bugs efficiently. Thanks @mlxd!
5 tasks
chaeyeunpark
added a commit
that referenced
this pull request
Jan 12, 2022
This will make #201 works as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Debugging with pypi supplied wheels is currently difficult due to the missing debug info. This PR ensure deub info is returned to the dynamic libraries by setting
ReleasetoRelWithDebInfo. This allows use of Lightning through debuggers, such as gdb, and lldb.Description of the Change:
Releasebuild type defaults toRelWithDebInfo.Benefits: Allows debugging symbols to be included in distributed binaries.
Possible Drawbacks: Larger wheel sizes.
Related GitHub Issues: