Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual destructors to StateVector classes #200

Merged
merged 4 commits into from
Dec 21, 2021
Merged

Add virtual destructors to StateVector classes #200

merged 4 commits into from
Dec 21, 2021

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Dec 21, 2021

Context: Fixes #188

Description of the Change: Add virtual destructors to StateVector and derived types.

Benefits: Prevents issues with destructor order calls.

Possible Drawbacks: None.

Related GitHub Issues: #188

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #200 (944742b) into master (978f739) will not change coverage.
The diff coverage is n/a.

❗ Current head 944742b differs from pull request most recent head 26d6f80. Consider uploading reports for the commit 26d6f80 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files           4        4           
  Lines         278      278           
=======================================
  Hits          277      277           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978f739...26d6f80. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2021

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   378 tests ±0     378 ✔️ ±0  0 💤 ±0  0 ±0 
2 233 runs  ±0  2 233 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 26d6f80. ± Comparison against base commit 978f739.

♻️ This comment has been updated with latest results.

@AmintorDusko
Copy link
Contributor

Short and Sweet!

@mlxd mlxd merged commit 17d895f into master Dec 21, 2021
@mlxd mlxd deleted the fix_destructor branch December 21, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add virtual destructor to StateVector class
2 participants