Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AVX default for PPC and ARM #182

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Conversation

chaeyeunpark
Copy link
Contributor

@chaeyeunpark chaeyeunpark commented Nov 25, 2021

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: Wheelbuilder does not work for PPC and ARM in 19a8a85 as AVX is enabled by default in CMake.

Description of the Change: Turned it off.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #182 (2d50d57) into master (19a8a85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files           4        4           
  Lines         185      185           
=======================================
  Hits          172      172           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a8a85...2d50d57. Read the comment docs.

@github-actions
Copy link
Contributor

Test Report (C++) on Ubuntu

       1 files  ±0         1 suites  ±0   0s ⏱️ ±0s
   345 tests ±0     345 ✔️ ±0  0 💤 ±0  0 ±0 
1 919 runs  ±0  1 919 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 2d50d57. ± Comparison against base commit 19a8a85.

@chaeyeunpark chaeyeunpark merged commit 4d8df75 into master Nov 25, 2021
@chaeyeunpark chaeyeunpark deleted the fix_cmake_for_ppc_arm branch November 25, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant