-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PL-Lightning to support new features in PL #179
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 182 184 +2
=========================================
+ Hits 182 184 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one Ali. Just a few small questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Great job @maliasadi
Context:
Current PL-Lightning is not compatible with new features in PL and as the result almost all
gates
andadjoint_jacobian
tests are FAILED. This PR updates the PL-lightning along with all tests to support new features in PL.Description of the Change:
op
was defined as a list of operations' inits and this test function worked properly as values ofop.num_params
andop.num_wires
were known for each operation. Now, with the recent updates, these values are not known and one must pass arguments a priori. Hence, each operation is being applied here with eachop
call without any needs on passing args and wires.JacobianTape
(and all the other tape subclasses!) are being deprecated in favour of the functions in theqml.gradients subpackage
.These files are mainly updated:
lightning_qubit.py
tests/test_gates.py
tests/test_adjoint_jacobian.py
Benefits:
PL-Lightning is compatible with new features in PL and there shouldn't be any failed tests
Related GitHub Issues:
n/a