Fix column major data layout in bindings #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlxd
changed the title
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 54 54
=========================================
Hits 54 54 Continue to review full report at Codecov.
|
|
[ch8073] |
antalszava
added a commit
that referenced
this pull request
Aug 11, 2021
This reverts commit 14ea923.
antalszava
added a commit
that referenced
this pull request
Aug 11, 2021
This reverts commit 1de97e6.
antalszava
added a commit
that referenced
this pull request
Aug 11, 2021
* Update method signatures for bound class (#125) * Add utility to get qubit number * Define gate overloads to enable run-time generalised calls * Update method signatures * Update changelog * Fix column major data layout in bindings (#126) * Fix column major data layout bindings * Update changelog * increment version, update changelog, gitignore a build folder * no Python version 3.6 * changelog for removing Python 3.6 * Revert "Fix column major data layout in bindings (#126)" This reverts commit 14ea923. * resolve changelog conflict * Update .github/CHANGELOG.md * Revert "Revert "Fix column major data layout in bindings (#126)"" This reverts commit 1de97e6. Co-authored-by: Lee James O'Riordan <[email protected]> Co-authored-by: Antal Szava <[email protected]>
antalszava
added a commit
that referenced
this pull request
Aug 17, 2021
* V17.0 increment version (#127) * Update method signatures for bound class (#125) * Add utility to get qubit number * Define gate overloads to enable run-time generalised calls * Update method signatures * Update changelog * Fix column major data layout in bindings (#126) * Fix column major data layout bindings * Update changelog * increment version, update changelog, gitignore a build folder * no Python version 3.6 * changelog for removing Python 3.6 * Revert "Fix column major data layout in bindings (#126)" This reverts commit 14ea923. * resolve changelog conflict * Update .github/CHANGELOG.md * Revert "Revert "Fix column major data layout in bindings (#126)"" This reverts commit 1de97e6. Co-authored-by: Lee James O'Riordan <[email protected]> Co-authored-by: Antal Szava <[email protected]> * organise changelog * version bump Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Lee James O'Riordan <[email protected]>
mlxd
added a commit
that referenced
this pull request
Aug 20, 2021
* V17.0 increment version (#127) * Update method signatures for bound class (#125) * Add utility to get qubit number * Define gate overloads to enable run-time generalised calls * Update method signatures * Update changelog * Fix column major data layout in bindings (#126) * Fix column major data layout bindings * Update changelog * increment version, update changelog, gitignore a build folder * no Python version 3.6 * changelog for removing Python 3.6 * Revert "Fix column major data layout in bindings (#126)" This reverts commit 14ea923. * resolve changelog conflict * Update .github/CHANGELOG.md * Revert "Revert "Fix column major data layout in bindings (#126)"" This reverts commit 1de97e6. Co-authored-by: Lee James O'Riordan <[email protected]> Co-authored-by: Antal Szava <[email protected]> * Update documentation for Python bindings * Add docstrings to gate matrix definitions * Add docstrings for all publically facing statevector methods * Fix incorrectly labelled gatecalls * Update doxygen comments to ignore anon namespaces * Move exc into namespace * Update missing gates * Enable build of C++ API with docs * Add C++ API to docs * Add C4 arch diagrams for lightning * Add sample C4 architecture for lightning using current design * Fix missing packages * Update documentation architecture * Prevent bindings from generating API docs * Update changelog Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Antal Szava <[email protected]> Co-authored-by: Tom Bromley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR fixes issues observed when passing numpy data in column-major layout to the row-major backed C++ bindings.
Description of the Change: Numpy data is forced to C-style (row-major) layout when passing numpy arrays to the C++ backend.
Benefits: This ensures correctness for both row and column major data layouts.
Possible Drawbacks: Column major layout data will experience a small overhead (though we should be using row-major everything).
Related GitHub Issues: #124