Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test suite in coverage #123

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Include test suite in coverage #123

merged 3 commits into from
Aug 9, 2021

Conversation

trbromley
Copy link
Contributor

The tests from PennyLane's device test suite will now be included when generating coverage reports. The makefile has also been updated to make using the test suite easier.

As we further modify some of the default.qubit-inherited methods in lightning.qubit, it'll be useful to harness the test suite tests for coverage so we don't have to replicated existing tests.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2021

Test Report (C++) on Ubuntu

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
118 tests ±0  118 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
370 runs  ±0  370 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e309d44. ± Comparison against base commit e309d44.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #123 (cac37ee) into master (2b26841) will increase coverage by 1.85%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #123      +/-   ##
===========================================
+ Coverage   98.14%   100.00%   +1.85%     
===========================================
  Files           3         3              
  Lines          54        54              
===========================================
+ Hits           53        54       +1     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
pennylane_lightning/lightning_qubit.py 100.00% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b26841...cac37ee. Read the comment docs.

@trbromley trbromley requested a review from mlxd August 6, 2021 21:14
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea and good job on this @trbromley !

@trbromley trbromley merged commit e309d44 into master Aug 9, 2021
@trbromley trbromley deleted the update_tests_suite branch August 9, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants