Build support for multiple architectures #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 3 3
Lines 54 54
=======================================
Hits 53 53
Misses 1 1 Continue to review full report at Codecov.
|
|
[ch7059] |
…d undefined values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR enables wheel-building for previously unsupported hardware architectures.
Description of the Change: Wheel-build support is added for the following hardware architectures:
(ppc64le), ARM64(aarch64)(arm64)The wheel-builder actions have also been separated to more easily allow selective building per PR created. This is partly due to the parsing order of the Github Actions YAML, where job
ifstatements are evaluated before any matrix statements, introducing skipped tests with undefined potentially overlapping labels.All x86_64 wheel build operations are run for each PR created. For Linux
ppc64leandaarch64, and MacOSarm64these are built only when a PR is merged with master, due to the additional overheads required.Benefits: This will simplify installation and use on the above platforms.
Possible Drawbacks: Additional efforts may be required to keep build-system up-to-date with any modifications or changes. Additional cluttering of workflows directory due to lack of support for nested Actions directories.