Add exactn cpp binding #1014
Merged
Add exactn cpp binding #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set before quantum state creation
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [ ] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
Lightning.tensor device adding TN backend
**Description of the Change:**
* Unit tests for gate support
* Unit tests for measurements
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-77835]
---------
Co-authored-by: Shuli Shu <[email protected]>
josephleekl
reviewed
Dec 6, 2024
maliasadi
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Thanks @LuisAlfredoNu for updating the design and naming conventions! Here are my suggestions for the implementation and docstrings. I'd be happy to review the PR again after addressing the unresolved comments
...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp
Outdated
Show resolved
Hide resolved
...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp
Outdated
Show resolved
Hide resolved
...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp
Outdated
Show resolved
Hide resolved
josephleekl
reviewed
Dec 6, 2024
josephleekl
previously approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks for the great work @LuisAlfredoNu, I've just added some minor comments!
LuisAlfredoNu
requested review from
AmintorDusko,
multiphaseCFD,
josephleekl and
maliasadi
AmintorDusko
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Nice work @LuisAlfredoNu!
I have nothing more to add, except for a few questions.
|
I will update UI stuff later in a following PR defined in [sc-80075]. CC @maliasadi |
multiphaseCFD
approved these changes
Dec 11, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Adding the backend Exact Tensor Network from
lightning.tensorto the Python layerDescription of the Change:
ExaTNCudaclassBenefits:
Refactor MPSTNCuda class to TNCuda class
mpsorexatn) to the constructor of theTNCuda class.Measurement class
expval()support can be get without changing current code base for the MPS backend.Possible Drawbacks:
qml.StatePrep()won't be supported for 'exatn'Related GitHub Issues:
[sc-77837][sc-77840]