Fix the missing ninja in AARCH64 Linux wheel recipe #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliasadi
added
ci:build_wheels
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1007 +/- ##
===========================================
- Coverage 95.70% 39.14% -56.57%
===========================================
Files 228 43 -185
Lines 35877 2956 -32921
===========================================
- Hits 34337 1157 -33180
- Misses 1540 1799 +259 ☔ View full report in Codecov by Sentry. |
maliasadi
requested review from
LuisAlfredoNu,
multiphaseCFD and
josephleekl
multiphaseCFD
approved these changes
Nov 26, 2024
maliasadi
removed
the
ci:use-gpu-runner
maliasadi
force-pushed
the
fix_aarch64_wheels
branch
from
4f8b8c2 to
d81379f
Compare
josephleekl
reviewed
Nov 27, 2024
|
Hey @maliasadi, this problem can be a fluke. I re-ran the failed test to check. I also checked the logs and there is nothing obvious there. The main problem is that Python is not finding LKokkos binaries. If the error persists, could you please check if the binaries are where they should be? |
|
The error is still there. Python can't find the binaries. |
|
Building both Kokkos and Lightning-Kokkos with GCC-13 fixed the last issue on Linux AARCH64. |
LuisAlfredoNu
approved these changes
Nov 28, 2024
5 tasks
maliasadi
added a commit
that referenced
this pull request
Nov 28, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [ ] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
PR #1007 forced all CIs to build and test Kokkos and Lightning-Kokkos
with GCC-13. [This change broke the LK testing
action](https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/12075970714/job/33676642868)
as we still use GCC11 for testing Lightning, and GCC13 for building
wheels inside manylinux_2_28. This PR reverts that change for now :(
**Description of the Change:**
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
---------
Co-authored-by: ringo-but-quantum <[email protected]>
multiphaseCFD
pushed a commit
that referenced
this pull request
Nov 28, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [ ] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
PR #1007 forced all CIs to build and test Kokkos and Lightning-Kokkos
with GCC-13. [This change broke the LK testing
action](https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/12075970714/job/33676642868)
as we still use GCC11 for testing Lightning, and GCC13 for building
wheels inside manylinux_2_28. This PR reverts that change for now :(
**Description of the Change:**
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
---------
Co-authored-by: ringo-but-quantum <[email protected]>
multiphaseCFD
pushed a commit
that referenced
this pull request
Dec 2, 2024
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [ ] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
PR #1007 forced all CIs to build and test Kokkos and Lightning-Kokkos
with GCC-13. [This change broke the LK testing
action](https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/12075970714/job/33676642868)
as we still use GCC11 for testing Lightning, and GCC13 for building
wheels inside manylinux_2_28. This PR reverts that change for now :(
**Description of the Change:**
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
---------
Co-authored-by: ringo-but-quantum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
ninjain Linux AARCH64 wheels recipe (Fix the issue reported here)Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-79255]