-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for controlled phase gate (ControlledPhaseShift/CPhase) #112
Comments
Important notes to double-check before a pull request: |
Yep, that is fine.
Comments are usually a good call
There should be no hard requirement for these, if they are not implemented for other existing C++ methods.
👍 We will do a review of the PR, and can make suggestions once it is created. Feel free to create it and tag people as needed. |
* Add CPhaseShiftGate with tests (#112) * Add CPhaseShiftGate with tests (#112) * Update support for ControlledPhaseShift Gate (#114) * Update test-cases for ControlledPhaseShift Gate (#114) * Update test-cases and formatting with clang-format-12 (#114) Co-authored-by: Lee James O'Riordan <[email protected]>
Use of the
ControlledPhaseShift
gate is currently supported by PennyLane default_qubit in Python (see here for supported gates and here for the Python implementation). This gate should also be natively supported in the C++ layer by lightning.qubit.This will require the following steps:
ControlledPhaseShift
class is created mirroring existing C++ gate structures (see here).The text was updated successfully, but these errors were encountered: