-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Temporarily disable lightning kokkos builds #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dime10!
One alternative solution might be to disable clang with C_COMPILER=$(which gcc)
and CXX_COMPILER==$(which g++)
make variables until this is fixed in actions/runner-images#8659.
Hello. You may have forgotten to update the changelog!
|
I don't mind either way, you're the one who proposed disabling kokkos tests 😅 |
Yeah, I'm just saying this is an alternative option. But I don't have any strong preference here :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 99.95% 99.56% -0.39%
==========================================
Files 22 42 +20
Lines 4509 7404 +2895
Branches 0 432 +432
==========================================
+ Hits 4507 7372 +2865
- Misses 2 16 +14
- Partials 0 16 +16 ☔ View full report in Codecov by Sentry. |
Looks like we're passing now (except codecov, which is expected to go down). Want to merge as is then? @maliasadi |
@dime10 Nvm, I see your comment. |
Co-authored-by: Ali Asadi <[email protected]>
Due to: actions/runner-images#8659