Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Temporarily disable lightning kokkos builds #337

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

dime10
Copy link
Contributor

@dime10 dime10 commented Oct 26, 2023

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dime10!

One alternative solution might be to disable clang with C_COMPILER=$(which gcc) and CXX_COMPILER==$(which g++) make variables until this is fixed in actions/runner-images#8659.

.github/workflows/check-catalyst.yaml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@dime10
Copy link
Contributor Author

dime10 commented Oct 26, 2023

Thanks @dime10!

One alternative solution might be to disable clang with C_COMPILER=$(which gcc) and CXX_COMPILER==$(which g++) make variables until this is fixed in actions/runner-images#8659.

I don't mind either way, you're the one who proposed disabling kokkos tests 😅

@maliasadi
Copy link
Member

Yeah, I'm just saying this is an alternative option. But I don't have any strong preference here :)

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03e814d) 99.95% compared to head (9babe76) 99.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   99.95%   99.56%   -0.39%     
==========================================
  Files          22       42      +20     
  Lines        4509     7404    +2895     
  Branches        0      432     +432     
==========================================
+ Hits         4507     7372    +2865     
- Misses          2       16      +14     
- Partials        0       16      +16     

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dime10
Copy link
Contributor Author

dime10 commented Oct 26, 2023

Looks like we're passing now (except codecov, which is expected to go down). Want to merge as is then? @maliasadi

@dime10 dime10 requested a review from maliasadi October 26, 2023 17:36
@maliasadi
Copy link
Member

maliasadi commented Oct 26, 2023

@dime10 Accepting my suggestion may resolve the Codecov failure

Nvm, I see your comment.

.github/workflows/check-catalyst.yaml Outdated Show resolved Hide resolved
@dime10 dime10 merged commit b729a19 into main Oct 26, 2023
16 of 17 checks passed
@dime10 dime10 deleted the dime10-patch-1 branch October 26, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants