-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable qpu.backend for IonQ backends #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution to the plugin, this looks great! 🎉
I would like to request one change in the implementation - I’m hesitant to add hardware-specific subclasses for different machines when there is no functional difference that needs to be supported. The call signature
qml.device(“ionq.qpu”, backend=“aria-1”, api_key=api_key, wires=2)
works well, and it won’t require a new version of the plugin to be released if IonQ adds, removes, or changes the names of any of the devices. This is generally also what we’ve done with other plugins - for examples, see the Honeywell or Rigetti plugin documentation.
Other than that, there are just a couple of small things that need to be added for tests and documentation :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 95.73% 93.79% -1.95%
==========================================
Files 5 5
Lines 305 306 +1
==========================================
- Hits 292 287 -5
- Misses 13 19 +6
☔ View full report in Codecov by Sentry. |
Thanks! Can you also run The CodeCov "reduced coverage" looks to me like it's an artifact of reformatting and not a change in how much of the plugin functionality is covered by the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
use the new
backend
field:to call
qpu.aria-1