Add IonQ native gateset support #55
Conversation
|
Will have to go to an older black version for formatting, I guess. The TODOs need to be resolved before submission, and the too-few-public-method check should be skipped/ignored somehow Can add tests once we finalize API shape |
|
Thanks @Cynocracy! |
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 88.85% 93.77% +4.92%
==========================================
Files 5 5
Lines 287 305 +18
==========================================
+ Hits 255 286 +31
+ Misses 32 19 -13
Continue to review full report at Codecov.
|
|
Ready for review! |
There was a problem hiding this comment.
I was able to submit a job to the simulator with the native gate set, but "ionq.qpu" is hanging currently for both "native" and "qis" gates.
Exciting to be able to work with these gates!
Most of my notes have to do with documentation.
We could probably add parameter-shift support later for these gates, but I think it's ok to leave them with grad_method = None for now.
pennylane_ionq/ops.py
Outdated
| """ | ||
| num_params = 1 | ||
| num_wires = 1 | ||
| grad_method = "None" |
There was a problem hiding this comment.
| grad_method = "None" | |
| grad_method = None |
There was a problem hiding this comment.
Do you have an example of how to add parameter shift support? I'd be happy to give it a shot (though maybe in a follow-up PR)
There was a problem hiding this comment.
The easiest way is to define the parameter_frequencies property.
If the parameter frequencies aren't manually defined, we can calculate them from the generator, defined via the generator method.
As these are single qubit operators with a single parameter, they will probably have the same frequencies as the standard rotation gates, namely [(1,)], but I'd have to double check.
|
Is the QPU job submitting fine but then not being processed? We have very long queue times at the moment: https://status.ionq.co/ |
|
Okay, after many mini fixups I think the docs render and don't have any glaring typos (I hope!) |
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Christina Lee <[email protected]>
|
docs look good! |
|
No problem :) I appreciate the thorough review! |
No description provided.