[Bug] Normalize probabilities #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 88.77% 88.85% +0.07%
==========================================
Files 5 5
Lines 285 287 +2
==========================================
+ Hits 253 255 +2
Misses 32 32
Continue to review full report at Codecov.
|
albi3ro
commented
Apr 21, 2022
antalszava
reviewed
Apr 21, 2022
There was a problem hiding this comment.
@albi3ro were the failures that we've seen results of a stochastic behaviour?
CHANGELOG.md
Outdated
| @@ -6,11 +6,16 @@ | |||
| `SimulatorDevice` class for general IonQ devices. | |||
| [(#50)](https://github.com/PennyLaneAI/PennyLane-IonQ/pull/50) | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| * Since the probabilities returned don't always perfectly sum to one, they are now normalized. | |||
There was a problem hiding this comment.
What probabilities are referred to here? Maybe good to rephrase from the user's point of view.
|
@antalszava When running an individual circuit locally, the errors were stochastic. |
albi3ro
commented
Apr 21, 2022
antalszava
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned probabilities do not always perfectly sum to one. This difference seems to be slight, about 1e-5, but it is enough to cause
np.random.choiceto complain. Therefore we now normalize the probabilities.