-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings on empty circuits, error when failure returned #43
Conversation
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 87.85% 88.77% +0.91%
==========================================
Files 5 5
Lines 280 285 +5
==========================================
+ Hits 246 253 +7
+ Misses 34 32 -2
Continue to review full report at Codecov.
|
if len(operations) == 0 and len(rotations) == 0: | ||
warnings.warn("Circuit is empty. Empty circuits return failures. Submitting anyway.") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
@@ -100,6 +125,7 @@ def fake_response(self, resource_id=None): | |||
@qml.qnode(dev) | |||
def circuit(): | |||
"""Reference QNode""" | |||
qml.PauliX(wires=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this the empty circuit causing the trouble ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
No description provided.