convert parameters to float for serialization #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 87.81% 84.28% -3.53%
==========================================
Files 5 5
Lines 279 280 +1
==========================================
- Hits 245 236 -9
- Misses 34 44 +10
Continue to review full report at Codecov.
|
albi3ro
changed the title
albi3ro
added a commit
that referenced
this pull request
Dec 9, 2021
* convert parameters to float for serialization (#41) * unwrap param, fix ndarray not json serializable * just cast to float instead. * warning if circuit empty, error if return with fail * only one change at a time, tests * black, code factor * Add a specific readthedocs yaml * requirements.txt * see if pinning numpy works Co-authored-by: Antal Szava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon locally running the PennyLane device suite tests, I was running into errors involving
ndarrayparameters not being JSON serializable. So I need to extract the value to being a float.