Add default timeout to requests #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for both catching (and fixing) this @dabacon! |
josh146
approved these changes
May 20, 2021
There was a problem hiding this comment.
Looks good from my end, just a small typo. Perhaps this is something we could consider making user-settable in the future?
Regarding the tests failing, I had a look at the logs and I don't think this is anything to worry about, looks due to GitHub not allowing GitHub secrets to be passed to PRs created from forks.
pennylane_ionq/api_client.py
Outdated
| @@ -129,6 +129,9 @@ def __init__(self, **kwargs): | |||
|
|
|||
| self.HEADERS = {"User-Agent": self.USER_AGENT} | |||
|
|
|||
| # Ten minute timout on requests. | |||
There was a problem hiding this comment.
Suggested change
| # Ten minute timout on requests. | |
| # Ten minute timeout on requests. |
|
Fixed typoooo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default timeout to requests of ten minutes. This is a timeout both on connect and request.
Without this, it is possible for the polling for complete jobs to hang indefinitely (we observed what we think was this while running against the QPU).
Ten minutes is a rather large timeout and was pulled out of a bag.