Enable multi circuit submission in PennyLane IonQ #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Adding code for batch circuit submit. * Remove unused imports. * Update version number. * Initialize self._samples in overloaded methods. * Various fixes. * Running existing unit tests from previous implementation and fixing bugs. * Correct unit test after updating pennylane baseline code to latest version. * Fix codefactor issues. * Run black code formatter. * Shots cannot be none in an IonQDevice. Remove check on shots. * Correct docstring comment. * Remove exeception handling code. * Remove self.histogram, replace with self.histograms. * Uniformize treatment of one vs multiple circuits. * Improve current_circuit_index handling with raising exceptions, add tests. * Reset samples in reset function. * Run black code formatter. * Remove unused includes. * Fix codefactor reported issues. * Adding doc string to method. * Fix docstring. * Add test with shot vector. * Add test with an observable that requires rotations for diagonalization. * Adding unit tests for using pennylane tracker in batch_execute method. Adding unit tests for user warnings. * Add tests for logging in batch_execute. * Run black. * Remove method override. * Implement review comments.' * Implement more review comments.' * Remove unused imports. * Remove unused imports. * Remove checks for BasisState, QubitStateVector and StatePrep because these are not supported by IonQ devices. * Fix code formatting. --------- Co-authored-by: Alex Preciado <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 96.93% 97.67% +0.74%
==========================================
Files 5 5
Lines 326 387 +61
==========================================
+ Hits 316 378 +62
+ Misses 10 9 -1 ☔ View full report in Codecov by Sentry. |
mudit2812
approved these changes
Oct 10, 2024
|
Amazing, thank you so much for this contribution @radumarg !! 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of this PR, but on the main repo, to let us run all the tests before merging to master (the other PR is on a fork and doesn't have access to the CI API token)