Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resting-state plots in executive summary #941

Merged
merged 13 commits into from
Sep 20, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 19, 2023

Closes #938 and closes #940.

Changes proposed in this pull request

  • Fix the description entity in the postprocessing carpet plot's query in the executive summary.
  • Sort task file entities for the executive summary.
    • Previously, only the task name and run number were used to sort the task section.
  • Build the task section names from task and run entities, along with any entities that are not constant across all of the subject's BOLD runs. This should help with datasets like the mobile-phenomics pilot, where single-echo and multi-echo runs are dissociated with the acq entity.
  • Skip the final task section (carpets + mean BOLD + boldref + registration plots) for concatenated resting-state data, since (1) there's a section higher up for the concatenated resting-state carpets and (2) there are no mean BOLD, bolref, or registration plots for "runs" generated by the concatenation workflow.
  • Move the "concatenated resting-state" carpet plot subsection from the "Anatomical Data" section to the "Functional Data" section.

@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Sep 19, 2023
@tsalo tsalo self-assigned this Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage is 93.54% of modified lines.

Files Changed Coverage
xcp_d/interfaces/execsummary.py 93.54%

📢 Thoughts on this report? Let us know!.

@tsalo
Copy link
Member Author

tsalo commented Sep 19, 2023

Need to convert run numbers from floats to ints in the subsection names.

EDIT: done
EDIT 2: nvm. not done
EDIT 3: okay actually done

@tsalo tsalo merged commit da6d866 into PennLINC:main Sep 20, 2023
4 checks passed
@tsalo tsalo deleted the executive-summary-rest branch September 20, 2023 13:32
@tsalo tsalo restored the executive-summary-rest branch October 9, 2023 20:32
tsalo added a commit to tsalo/xcp_d that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
1 participant