-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --bids-filter-file
parameter
#686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our test data aren't really good for testing the filter file, but I've tested on different data locally and it worked well. |
--bids-filter-file
parameter
@mattcieslak would you be willing to review the documentation? Here's the section that's been modified. I just don't know if the info I've added is detailed/comprehensive enough for users. |
mattcieslak
reviewed
Nov 28, 2022
mattcieslak
approved these changes
Nov 28, 2022
Thanks @mattcieslak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #685 and closes #591.
Changes proposed in this pull request
--bids-filter-file
parameter to CLI.mni_to_t1w
throughout package totemplate_to_t1w
.t1w_to_mni
throughout package tot1w_to_template
.Documentation that should be reviewed
https://xcp-d--686.org.readthedocs.build/en/686/usage.html#filtering-inputs-with-bids-filter-files