Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --bids-filter-file parameter #686

Merged
merged 12 commits into from
Nov 29, 2022
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 25, 2022

Closes #685 and closes #591.

Changes proposed in this pull request

  • Add --bids-filter-file parameter to CLI.
  • Change mni_to_t1w throughout package to template_to_t1w.
  • Change t1w_to_mni throughout package to t1w_to_template.

Documentation that should be reviewed

https://xcp-d--686.org.readthedocs.build/en/686/usage.html#filtering-inputs-with-bids-filter-files

@tsalo tsalo added the enhancement New feature or request label Nov 25, 2022
@tsalo
Copy link
Member Author

tsalo commented Nov 28, 2022

Our test data aren't really good for testing the filter file, but I've tested on different data locally and it worked well.

@tsalo tsalo changed the title Add bids-filter-file parameter Add --bids-filter-file parameter Nov 28, 2022
@tsalo
Copy link
Member Author

tsalo commented Nov 28, 2022

@mattcieslak would you be willing to review the documentation? Here's the section that's been modified. I just don't know if the info I've added is detailed/comprehensive enough for users.

@tsalo
Copy link
Member Author

tsalo commented Nov 28, 2022

Thanks @mattcieslak!

@tsalo tsalo merged commit fe4ae66 into PennLINC:main Nov 29, 2022
@tsalo tsalo deleted the bids-filter-file branch November 29, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filtering by session Add a flag that filters out sessions
2 participants