Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing affines don't change across XCP runs #649

Merged
merged 20 commits into from
Nov 18, 2022
Merged

Testing affines don't change across XCP runs #649

merged 20 commits into from
Nov 18, 2022

Conversation

kahinimehta
Copy link
Collaborator

Closes #527

tsalo
tsalo reviewed Nov 7, 2022
View reviewed changes
tsalo
tsalo reviewed Nov 7, 2022
View reviewed changes
tsalo
tsalo reviewed Nov 7, 2022
View reviewed changes
tsalo
tsalo reviewed Nov 7, 2022
View reviewed changes
@tsalo tsalo added the testing Improving testing in the project. label Nov 7, 2022
@kahinimehta kahinimehta requested a review from tsalo November 8, 2022 14:49
tsalo
tsalo approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! I want to integrate the new tests into the pytest code, but I can do that in a followup PR.

@kahinimehta kahinimehta merged commit f486ea4 into main Nov 18, 2022
@tsalo tsalo deleted the testetc branch September 28, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsalo tsalo tsalo approved these changes

Assignees
No one assigned
Labels
testing Improving testing in the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEST] Are the affines changing across XCP?
2 participants
@kahinimehta @tsalo