Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rerun alff if num threads changes #1263

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Conversation

mattcieslak
Copy link
Contributor

The n_threads input shouldn't trigger a re-run if it changes. This prevents that from happening

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (bc45d11) to head (fba9fc3).
Report is 47 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1263   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files          59       59           
  Lines        7218     7218           
  Branches     1064     1064           
=======================================
  Hits         5661     5661           
  Misses       1286     1286           
  Partials      271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Sep 14, 2024
@tsalo tsalo merged commit ddd7a55 into main Sep 14, 2024
21 checks passed
@tsalo tsalo deleted the fix/nohash-alff-threads branch September 14, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants