Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check for -p none and --custom-confounds #1222

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 1, 2024

Closes none, but addresses an issue reported by @juliegrier. Basically, it's currently unclear how XCP-D works if users use -p none (no denoising) and --custom-confounds (external regressors to be used for denoising). Logically, it makes more sense to automatically change -p to custom in that scenario than to ignore --custom-confounds.

Changes proposed in this pull request

  • If nuisance regressors are set to none, but custom confounds are provided, then issue a warning and change the nuisance regressor option to custom.

@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Aug 1, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (14de282) to head (59754c5).
Report is 53 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1222   +/-   ##
=======================================
  Coverage   84.28%   84.29%           
=======================================
  Files          54       54           
  Lines        7064     7067    +3     
  Branches     1027     1028    +1     
=======================================
+ Hits         5954     5957    +3     
  Misses        850      850           
  Partials      260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 8f93b13 into PennLINC:main Aug 2, 2024
21 checks passed
@tsalo tsalo deleted the clarify-custom-none branch August 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant