Explicitly check for -p none
and --custom-confounds
#1222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes none, but addresses an issue reported by @juliegrier. Basically, it's currently unclear how XCP-D works if users use
-p none
(no denoising) and--custom-confounds
(external regressors to be used for denoising). Logically, it makes more sense to automatically change-p
tocustom
in that scenario than to ignore--custom-confounds
.Changes proposed in this pull request
none
, but custom confounds are provided, then issue a warning and change the nuisance regressor option tocustom
.