Update to 1.7.2 GrassCutter w/ fixes and new features. #2
Conversation
There was a problem hiding this comment.
Seems good, do you know of any other errors?
I'm asking since don't maintain it especially since GrasscutterCommandGenerator have similiar function
|
Also I really appreciate your work, it's rare to see someone asking for my plugins |
No, at least not with my export.
I noticed that today, after I made all of the patches - before even testing server implementation xD |
|
If you say that there aren't any errors that you found then I guess it's good to go |
| @@ -67,12 +67,19 @@ public final class Import implements CommandHandler { | |||
| CommandHandler.sendMessage(targetPlayer,"Artifacts import disabled"); | |||
| } | |||
| } | |||
|
|
|||
| if (GenshinImporter.getPluginConfig().Weapons) { | |||
| Datareader.weapons(targetPlayer, filename); | |||
There was a problem hiding this comment.
Also you forgot to add weapons function to datareader
There was a problem hiding this comment.
Whoops, seems that I've missed that when making commits to Git :(
|
I'll fix that but Datareader doesn't have weapons function which is mentioned here |
Thanks for your work on this plugin!
I tried here to fix issues with my GOOD scanned from official servers.
Was dissapointed to see missing characters and weapon import (main reason why I noticed your project), and implemented that myself.
Weapon import should be more futureproof, and does not require internal resources like your original version of artifact/character import, although I haven't tested that thoroughly with all weapons.