Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup incomplete CLI command #376

Merged

Conversation

WilliamXieCrypto
Copy link
Contributor

Following this issue #366

Open a PR to cleanup the incomplete&half-implemented CLI command.

assert!(self.free.len() == 1);
let _key_name = self.free[0].clone();

abscissa_tokio::run(&APP, async { unimplemented!() }).unwrap_or_else(|e| {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unimplemented!()

assert!(self.free.len() == 1);
let _key_name = self.free[0].clone();

abscissa_tokio::run(&APP, async { unimplemented!() }).unwrap_or_else(|e| {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unimplemented!()

@WilliamXieCrypto WilliamXieCrypto marked this pull request as ready for review April 1, 2022 08:05
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricBolten EricBolten merged commit ffc860d into PeggyJV:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants