This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2271] Add metrics to Parallel Download pipeline #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatthewenglish
force-pushed
the
plll-dl-pipe-metrix
branch
from
a0b7ae5
to
ae2b26b
Compare
smatthewenglish
force-pushed
the
plll-dl-pipe-metrix
branch
from
17b4893
to
c5f88d9
Compare
smatthewenglish
removed
the
work in progress
shemnon
suggested changes
Feb 27, 2019
| @@ -60,7 +60,7 @@ | |||
|
|
|||
| private final EnumSet<MetricCategory> enabledCategories = EnumSet.allOf(MetricCategory.class); | |||
|
|
|||
| PrometheusMetricsSystem() {} | |||
| public PrometheusMetricsSystem() {} | |||
There was a problem hiding this comment.
This is deliberately not public. use init()
Suggested change
| public PrometheusMetricsSystem() {} | |
| PrometheusMetricsSystem() {} |
| private MutableBlockchain localBlockchain; | ||
| private BlockchainSetupUtil<Void> otherBlockchainSetup; | ||
| private Blockchain otherBlockchain; | ||
| private MetricsSystem metricsSystem = new PrometheusMetricsSystem(); |
There was a problem hiding this comment.
Suggested change
| private MetricsSystem metricsSystem = new PrometheusMetricsSystem(); | |
| private MetricsSystem metricsSystem = PrometheusMetricsSystem.init(); |
| metricsSystem.createCounter( | ||
| MetricCategory.SYNCHRONIZER, | ||
| "inboundQueueCounter", | ||
| "parallel download pipeline metric"); |
There was a problem hiding this comment.
More descriptive, such as "count of queue items that started processing"
|
|
||
| final List<Observation> metrics = | ||
| metricsSystem.getMetrics(MetricCategory.SYNCHRONIZER).collect(Collectors.toList()); | ||
| for (Observation observation : metrics) { |
There was a problem hiding this comment.
I think what would look better is
assertThat(metrics).contains(new Observation(...), new Observation(...));
| metricsSystem.getMetrics(MetricCategory.SYNCHRONIZER).collect(Collectors.toList()); | ||
| for (Observation observation : metrics) { | ||
| if (observation.getMetricName().equals("outboundQueueCounter")) { | ||
| assertThat(observation.getValue()).isEqualTo(5.0); |
There was a problem hiding this comment.
Hmm.... why aren't the inbound and outbound counts equal? Why is there one more inbound?
smatthewenglish
force-pushed
the
plll-dl-pipe-metrix
branch
from
9520cbf
to
44ed44d
Compare
smatthewenglish
force-pushed
the
plll-dl-pipe-metrix
branch
from
44ed44d
to
937de64
Compare
shemnon
approved these changes
Feb 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds metrics to Parallel Download pipeline, and an associated unit test.
Fixed Issue(s)