This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Change ExpectBlockNumber to require at least the specified block number #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er instead of exactly that block number. Otherwise tests fail if the miner finds a new block before the check runs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Since the miner is constantly adding new blocks, it doesn't make any sense to wait for a specific block number as the chain height may have progressed beyond that by the time the check runs causing a failure. Instead we need to check that the chain is at least that height - higher is fine.
Also adds in a better error message when
NettyP2PNetworkfails to start so we hopefully get a stack trace and can see why.