This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix benchmark compilation #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errorific
reviewed
Feb 26, 2019
Jenkinsfile
Outdated
| @@ -54,7 +54,7 @@ try { | |||
| docker.image(build_image).inside("--link ${d.id}:docker") { | |||
| try { | |||
| stage(stage_name + 'Prepare') { | |||
| sh './gradlew --no-daemon --parallel clean compileJava compileTestJava assemble' | |||
| sh './gradlew --no-daemon --parallel clean compileJava compileTestJava compileJmh assemble' | |||
There was a problem hiding this comment.
Change also needs to happen on lines 81, 105, & 135
There was a problem hiding this comment.
I considered that but we actually only need one task to do the compilation - the results aren't used so no point in having them all do it.
There was a problem hiding this comment.
Actually may be better to make it its own stage like javadoc is...
shemnon
approved these changes
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add compileJmh to the build process to ensure that benchmark code at least compiles. Fix the compilation error.