This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[BUG] rpc tests can use 127.0.0.1 loopback rather than localhost #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errorific
added a commit
to Errorific/pantheon
that referenced
this pull request
Feb 26, 2019
Errorific
added a commit
that referenced
this pull request
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under windows when run in some environments we're seeing the tests call back from the 127.0.0.1 loopback address rather than localhost and run afoul of the host whitelisting. This changes that so 127.0.0.1 is a default accepted whitelist host