This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Create peer discovery packets on a worker thread #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is potentially slow causing the Vertx queue to back up.
CjHare
approved these changes
Feb 25, 2019
|
LGTM if those who are vertx familiar like it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Creating peer discovery packets involves cryptographically signing the contents which is a fairly expensive operation. When we do that for a bunch of messages at once, such as when bonding to newly discovered peers, it can cause the Vertx event thread to be blocked for multiple seconds, causing errors and slow processing of incoming messages.
This change moves creation and signing of packets onto worker threads so that the event queue isn't blocked but ensures that the created packet is then delivered back on the event queue to maintain the single-threaded behaviour the code requires.