Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PAN-1930] bootnodes not on whitelist - improve errors #904

Merged
merged 6 commits into from
Feb 19, 2019
Merged

[PAN-1930] bootnodes not on whitelist - improve errors #904

merged 6 commits into from
Feb 19, 2019

Conversation

macfarla
Copy link
Contributor

PR description

Improve testing for errors when bootnodes not in nodes-whitelist

Fixed Issue(s)

fixes #PAN-2116

mark-terry
mark-terry reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@mark-terry mark-terry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few comments.

pantheon/src/test/java/tech/pegasys/pantheon/util/PermissioningConfigurationValidatorTest.java Outdated Show resolved Hide resolved
pantheon/src/test/java/tech/pegasys/pantheon/util/PermissioningConfigurationValidatorTest.java Outdated Show resolved Hide resolved
pantheon/src/test/java/tech/pegasys/pantheon/util/PermissioningConfigurationValidatorTest.java Outdated Show resolved Hide resolved
@macfarla macfarla merged commit 257cddf into PegaSysEng:master Feb 19, 2019
@macfarla macfarla deleted the pan-1930-bootnodes-not-on-whitelist-errors branch February 19, 2019 06:42
rain-on pushed a commit to rain-on/pantheon that referenced this pull request Feb 20, 2019
@macfarla
[PAN-1930] bootnodes not on whitelist - improve errors (PegaSysEng#904)
881bc41 
* enhanced test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mark-terry mark-terry mark-terry approved these changes

@Errorific Errorific Errorific approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macfarla @Errorific @mark-terry