This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Use absolute datapath instead of relative. #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 20, 2019
When using the data-path internally use an absolute version instead of the path instead of a relative form. This fixes a null pointer exception when the data-path is set to an empty string (in a TOML config using `data-path=""` or CLI using `--data-path=`) and interprets that empty string to be the current working directory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The NPE was caused by setting data-path to an empty string (either via TOML
data-path=""or CLI--data-path=. This is a relative directory with no direct parent. The empty path is also an alias for the current directory, so returning the absolute path will result in a path with a parent.Fixed Issue(s)
fixes #854