This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Unit tests of BlockBroadcaster #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekellstrand
reviewed
Feb 18, 2019
| @@ -561,4 +566,25 @@ public void shouldNotImportBlocksThatAreAlreadyBeingImported() { | |||
|
|
|||
| verify(ethScheduler, times(1)).scheduleSyncWorkerTask(any(Supplier.class)); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Idea: Would it test any addition workflow (I'm not sure offhand) if you added a third node? ie, create the block on first node like currently. have node 2 process everything with native (non-test code), and wait for the message to arrive or process on 3rd node?
ajsutton
reviewed
Feb 18, 2019
| .mixHash(Hash.ZERO) | ||
| .nonce(0L) | ||
| .blockHashFunction(MainnetBlockHashFunction::createHash) | ||
| .buildBlockHeader(); |
There was a problem hiding this comment.
You can just use BlockHeaderTestFixure to create a simple test block.
smatthewenglish
force-pushed
the
better-propaganda
branch
from
65e6eb3
to
9215bb6
Compare
ajsutton
approved these changes
Feb 19, 2019
| } | ||
|
|
||
| @Test | ||
| public void blockPropagationRejectOnHasSeenBlock() { |
There was a problem hiding this comment.
We probably don't need this one given we have the test above to check we send only to peers that haven't seen the block.
smatthewenglish
added a commit
to smatthewenglish/pantheon
that referenced
this pull request
Feb 19, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
includes two unit tests:
--> one the confirms the
propagateBlockmethod onEthPeeris invoked when all criteria are satisfied.--> one that confirms the
propagateBlockmethod onEthPeeris not invoked when all criteria are not satisfied.NOTE
when 808 lands the change set of this code will be reduced to only the file
BlockBroadcasterTest.javaFixed Issue(s)