Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PAN-2239] Disconnect peer removed from node whitelist #877

Merged
merged 16 commits into from
Feb 18, 2019
Merged

[PAN-2239] Disconnect peer removed from node whitelist #877

merged 16 commits into from
Feb 18, 2019

Conversation

lucassaldanha
Copy link
Contributor

PR description

  • Created a NodeWhitelistUpdated event that will be trigger every time a modification in the node whitelist occurs (containing any added/removed nodes)
  • PeerDiscoveryController subscribes to NodeWhitelistUpdated events and evict peers from peer table on receiving the event. This triggers a PeerDropped event.
  • Created the PeerDropped event that will cause NettyP2PNetwork to disconnect from the peer that has been removed from the peer table

@lucassaldanha lucassaldanha changed the title [PAN-2239] Disconnect from peer removed from node whitelist [PAN-2239] Disconnect peer removed from node whitelist Feb 17, 2019
macfarla
macfarla approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha merged commit 3c2be36 into PegaSysEng:master Feb 18, 2019
@lucassaldanha lucassaldanha deleted the PAN-2239 branch February 18, 2019 03:34
rain-on pushed a commit to rain-on/pantheon that referenced this pull request Feb 18, 2019
@lucassaldanha
[PAN-2239] Disconnect peer removed from node whitelist (PegaSysEng#877)
157bead
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
permissioning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucassaldanha @macfarla