This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Reduce logging noise from invalid peer discovery packets and handshaking #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugh to locate the source of the rejection.
…low through the handshake process.
ajsutton
changed the title
mbaxter
approved these changes
Feb 18, 2019
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 18, 2019
…ing (PegaSysEng#876) * Reduce logging for invalid peer discovery packets. The message is enough to locate the source of the rejection. * Reduce ECIESHandshaker logging to trace since it documents a normal flow through the handshake process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The debug logs are full of invalid peer discovery packet exceptions. These are just normal validation failures which ideally wouldn't have required throwing an exception at all (not an exceptional condition). The source of the validation failure can be located using the error message so exclude the stack trace from the logs.
Additionally the ECIESHandshaker print a debug message for every step of the process which should be at trace level.