This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Select new pivot block when world state becomes unavailable #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eFuture that we keep rewriting.
…vot block - it makes it look like fast sync isn't in progress and will thus force full sync if the user restarted pantheon before we actually picked a new pivot.
mbaxter
approved these changes
Feb 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
During a fast sync, it's possible that the world state download will still because all our peers have pruned the state for the pivot block. In that case we need to select a newer pivot block and retry fast sync.
This PR does not attempt to detect a stalled
WorldStateDownload, but it introduces aWorldStateUnavailableexception which, if it were ever thrown from the world state downloader, would abort the current fast sync and begin the process again so it can select a new pivot block.Note: Builds on #868 because
FutureUtilsis nice.