This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-2218] RPC auth config validation + tests. #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-terry
changed the title
macfarla
reviewed
Feb 13, 2019
| password = "$2a$10$l3GA7K8g6rJ/Yv.YFSygCuI9byngpEzxgWS9qEg5emYDZomQW7fGC" | ||
| groups = ["admin"] | ||
| permissions = ["eth:*", "perm:*"] | ||
| roles = ["net"] |
There was a problem hiding this comment.
in my PR I used / instead of :
what you have done is what the design doc says. I can't think right now why I used / so I guess that needs changing
There was a problem hiding this comment.
The / will be JsonRpcMethod and NetListeningTest and one or two auth.toml files
If you feel like doing it, otherwise I will get to it later this afternoon
macfarla
approved these changes
Feb 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Added validation for RPC authentication configuration at start up.
Fixed Issue(s)
#NC-2218