This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix 'the Input Is Too Long' Error on Windows #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekellstrand
reviewed
Feb 13, 2019
added 2 commits
February 13, 2019 23:52
|
@glethuillier - We are trying to do an RC tomorrow. Would you like to do the honors of pressing "Squash and merge" (and probably "update branch")? |
ghost
deleted the
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Feb 20, 2019
Fix for the _“The input line is too long”_ error on Windows. This fix makes Gradle generate a shortened but operational command in `pantheon.bat`. The modified `pantheon.bat`, instead of explicitly referencing each .jar individually when initializing the classpath, uses the wildcard character `*` instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fix for the “The input line is too long” error on Windows.
This fix makes Gradle generate a shortened but operational command in
pantheon.bat.The modified
pantheon.bat, instead of explicitly referencing each .jar individually when initializing the classpath, uses the wildcard character*instead (on this point, see the this link).A longer-term solution could be to generate a fat jar, for instance. Whatever the chosen solution, the suggested fix is designed to be easily removed when the time comes.
It is therefore intended as a non-intrusive fix.
Successfully tested on Windows 7 Ultimate (64-bit version), Windows 8.1 Pro (64-bit version), and Windows 10 Enterprise Edition.
Fixed Issue
Fixes #839.