This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-2268] Handle partial responses to get receipts requests #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…til they have all been received.
…ncomplete-receipts-reply
…ncomplete-receipts-reply
mbaxter
approved these changes
Feb 7, 2019
…ncomplete-receipts-reply
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When requesting receipts for blocks, the remote peer may only return a subset of the requested receipts and we then need to send an additional request for the remaining receipts.
Also removes the restriction on
AbstractRetryingPeerTaskthat it return aListof data - this was only required so it could check for empty responses so aPredicateis now passed in to enable that check with a completely generic type andGetReceiptsForHeadersTaskcan then return aMapof header to receipts.And as a bonus, it turns out the new
GetReceiptsForHeadersthat handles the retrying is also the perfect place to handle headers with empty receipt roots so we can avoid requesting them over the network.