This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-2200] Update WorldStateDownloader to only filter out known code requests #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR addresses an issue where the
WorldStateDownloadercan be overly aggressive in filtering outgoing network requests for node data. Previously, we would filter out node data requests when we have the to-be-requested data stored locally. This can cause us to miss downloading some world state in cases where an account contains code that exactly matches an account or account storage trie node.For now, I've updated the downloader to only filter out requests for known code, which should be safe. We should be able to do more advanced filtering on trie nodes by inspecting our local data, but I am deferring that work for now.